Messages in this thread | | | Date | Thu, 24 Aug 2023 21:03:07 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: userspace-consumer: Use atomic operation |
| |
On Thu, Aug 24, 2023 at 12:32:22PM -0700, Zev Weiss wrote: > On Thu, Aug 24, 2023 at 09:55:41AM PDT, Mark Brown wrote:
> > Unless there's a strong positive reason to specifically use atomics it > > seems better to avoid them, like I say they're full of landmines with > > unexpeted behaviours and therefore something that sets off alarm bells > > about needing careful study, the mutex is going to be less preformant > > but is also much more clearly correct.
> I assume this patch was posted as a result of a comment I made on the > original patch [1], but in hindsight I probably shouldn't have suggested it
I'm literally on a train right now with very intermittent connectivity:
Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.
> [1] https://lore.kernel.org/lkml/d3ea0fe2-00bb-493b-aca7-ba7a31bd3c78@hatter.bewilderbeest.net/
That's review of "regulator: userspace-consumer: Add regulator event support". Sorry, I had managed to reply on that thread but it keeps getting buried under an avalanche of enormous serieses.
> as it's a relatively minor issue either way -- I think the other things > brought up in that email are much more significant concerns. Honestly I > don't think that patch should be applied in its present form, though I see > it's still present in the regulator/for-next and regulator/for-6.6 branches > -- Mark, do you intend to include it as-is in your pull request to Linus for > the 6.6 merge window?
If it's there I'm intending to include it, though I'm still thinking about the numbers. [unhandled content-type:application/pgp-signature] | |