Messages in this thread | | | Date | Wed, 23 Aug 2023 14:12:24 +0800 | Subject | Re: [PATCH 1/2] RDMA/rxe: add missing newline to rxe_set_mtu message | From | Zhu Yanjun <> |
| |
在 2023/8/23 10:13, Li Zhijian 写道: > A newline help flushing message out.
rxe_info_dev will finally call printk to output information.
In this link https://github.com/torvalds/linux/blob/master/Documentation/core-api/printk-basics.rst, " All printk() messages are printed to the kernel log buffer, which is a ring buffer exported to userspace through /dev/kmsg. The usual way to read it is using dmesg. " Do you mean that a new line will help the kernel log buffer flush message out?
Zhu Yanjun > > Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> > --- > drivers/infiniband/sw/rxe/rxe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c > index 54c723a6edda..cb2c0d54aae1 100644 > --- a/drivers/infiniband/sw/rxe/rxe.c > +++ b/drivers/infiniband/sw/rxe/rxe.c > @@ -161,7 +161,7 @@ void rxe_set_mtu(struct rxe_dev *rxe, unsigned int ndev_mtu) > port->attr.active_mtu = mtu; > port->mtu_cap = ib_mtu_enum_to_int(mtu); > > - rxe_info_dev(rxe, "Set mtu to %d", port->mtu_cap); > + rxe_info_dev(rxe, "Set mtu to %d\n", port->mtu_cap); > } > > /* called by ifc layer to create new rxe device.
| |