Messages in this thread | | | Date | Thu, 24 Aug 2023 08:07:24 +0900 | Subject | Re: [PATCH 1/2] ata: pata_ep93xx: fix error return code in probe | From | Damien Le Moal <> |
| |
On 8/23/23 18:47, Nikita Shubin via B4 Relay wrote: > From: Nikita Shubin <nikita.shubin@maquefel.me> > > Return -ENOMEM from ep93xx_pata_probe() if devm_kzalloc() or > ata_host_alloc() fails. > > Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
Doesn't this need a Fixes tag and Cc: stable ?
This is not really a bug fix, but might as well be complete with the fix :)
> --- > drivers/ata/pata_ep93xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/ata/pata_ep93xx.c b/drivers/ata/pata_ep93xx.c > index c6e043e05d43..4ce0f37c7a89 100644 > --- a/drivers/ata/pata_ep93xx.c > +++ b/drivers/ata/pata_ep93xx.c > @@ -939,7 +939,7 @@ static int ep93xx_pata_probe(struct platform_device *pdev) > > drv_data = devm_kzalloc(&pdev->dev, sizeof(*drv_data), GFP_KERNEL); > if (!drv_data) { > - err = -ENXIO; > + err = -ENOMEM; > goto err_rel_gpio; > } > > @@ -952,7 +952,7 @@ static int ep93xx_pata_probe(struct platform_device *pdev) > /* allocate host */ > host = ata_host_alloc(&pdev->dev, 1); > if (!host) { > - err = -ENXIO; > + err = -ENOMEM; > goto err_rel_dma; > } > >
-- Damien Le Moal Western Digital Research
| |