Messages in this thread | | | From | John Stultz <> | Date | Wed, 23 Aug 2023 14:25:50 -0700 | Subject | Re: [PATCH v5 13/19] sched: Split out __sched() deactivate task logic into a helper |
| |
On Wed, Aug 23, 2023 at 2:13 PM kernel test robot <lkp@intel.com> wrote: > > Hi John, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on tip/locking/core] > [also build test WARNING on linus/master tip/auto-latest v6.5-rc7] > [cannot apply to tip/sched/core tip/master next-20230823] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/John-Stultz/sched-Unify-runtime-accounting-across-classes/20230821-121604 > base: tip/locking/core > patch link: https://lore.kernel.org/r/20230819060915.3001568-14-jstultz%40google.com > patch subject: [PATCH v5 13/19] sched: Split out __sched() deactivate task logic into a helper > config: riscv-allnoconfig (https://download.01.org/0day-ci/archive/20230824/202308240439.2aDXO6Ks-lkp@intel.com/config) > compiler: riscv64-linux-gcc (GCC) 13.2.0 > reproduce: (https://download.01.org/0day-ci/archive/20230824/202308240439.2aDXO6Ks-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot <lkp@intel.com> > | Closes: https://lore.kernel.org/oe-kbuild-all/202308240439.2aDXO6Ks-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> kernel/sched/core.c:6565:6: warning: no previous prototype for 'try_to_deactivate_task' [-Wmissing-prototypes] > 6565 | bool try_to_deactivate_task(struct rq *rq, struct task_struct *p, unsigned long state) > | ^~~~~~~~~~~~~~~~~~~~~~
Ah, thanks for pointing this out. Switched it to being static.
thanks -john
| |