lkml.org 
[lkml]   [2023]   [Aug]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] platform/x86/amd/pmf: Fix a missing cleanup path
    Date
    On systems that support slider notifications but don't otherwise support
    granular slider the SPS cleanup path doesn't run.

    This means that loading/unloading/loading leads to failures because
    the sysfs files don't get setup properly when reloaded.

    Add the missing cleanup path.

    Fixes: 33c9ab5b493a ("platform/x86/amd/pmf: Notify OS power slider update")
    Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
    ---
    drivers/platform/x86/amd/pmf/core.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/platform/x86/amd/pmf/core.c b/drivers/platform/x86/amd/pmf/core.c
    index 7780705917b76..8f93681c5c9c5 100644
    --- a/drivers/platform/x86/amd/pmf/core.c
    +++ b/drivers/platform/x86/amd/pmf/core.c
    @@ -317,7 +317,8 @@ static void amd_pmf_init_features(struct amd_pmf_dev *dev)

    static void amd_pmf_deinit_features(struct amd_pmf_dev *dev)
    {
    - if (is_apmf_func_supported(dev, APMF_FUNC_STATIC_SLIDER_GRANULAR)) {
    + if (is_apmf_func_supported(dev, APMF_FUNC_STATIC_SLIDER_GRANULAR) ||
    + is_apmf_func_supported(dev, APMF_FUNC_OS_POWER_SLIDER_UPDATE)) {
    power_supply_unreg_notifier(&dev->pwr_src_notifier);
    amd_pmf_deinit_sps(dev);
    }
    base-commit: 65c6ea33e7f63799090158866cdcfdfe8d63ce16
    --
    2.34.1

    \
     
     \ /
      Last update: 2023-08-23 20:56    [W:4.348 / U:1.820 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site