Messages in this thread | | | Date | Tue, 22 Aug 2023 11:49:50 -0400 | From | Benjamin Poirier <> | Subject | Re: [PATCH] selftests: Keep symlinks, when possible |
| |
On 2023-08-22 15:58 +0200, Björn Töpel wrote: > From: Björn Töpel <bjorn@rivosinc.com> > > When kselftest is built/installed with the 'gen_tar' target, rsync is > used for the installation step to copy files. Extra care is needed for > tests that have symlinks. Commit ae108c48b5d2 ("selftests: net: Fix > cross-tree inclusion of scripts") added '-L' (transform symlink into > referent file/dir) to rsync, to fix dangling links. However, that > broke some tests where the symlink (being a symlink) is part of the > test (e.g. exec:execveat). > > Use rsync's '--copy-unsafe-links' that does right thing. > > Fixes: ae108c48b5d2 ("selftests: net: Fix cross-tree inclusion of scripts") > Signed-off-by: Björn Töpel <bjorn@rivosinc.com> > --- > tools/testing/selftests/lib.mk | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Benjamin Poirier <bpoirier@nvidia.com>
Thank you for the fix.
| |