Messages in this thread | | | Date | Tue, 22 Aug 2023 16:34:25 +0200 | Subject | Re: [PATCH v5 2/2] arm64: dts: qcom: sc7180: Add sku_id and board id for lazor/limozeen | From | Konrad Dybcio <> |
| |
On 22.08.2023 12:03, Sheng-Liang Pan wrote: > SKU ID 10: Lazor LTE+Wifi, no-esim (Strapped 0 X 0) > SKU ID 15: Limozeen LTE+Wifi, TS, no esim (Strapped 1 X 0) > SKU ID 18: Limozeen LTE+Wifi, no TS, no esim (Strapped X 0 0) > > Even though the "no esim" boards are strapped differently than > ones that have an esim, the esim isn't represented in the > device tree so the same device tree can be used for LTE w/ esim > and LTE w/out esim. > > add BRD_ID(0, Z, 0) = 10 for new board with ALC5682i-VS > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- Minor style nits since Doug already suggested a v6:
- please add a space between /delete-node/ and the &reference after it - keep properties (e.g. pinctrl-) like this: property-n property-names
Konrad
| |