Messages in this thread | | | Date | Tue, 22 Aug 2023 14:05:43 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] bpf: task_group_seq_get_next: cleanup the usage of get/put_task_struct |
| |
On 08/21, Yonghong Song wrote: > > > On 8/21/23 1:03 PM, Oleg Nesterov wrote: > >get_pid_task() makes no sense, the code does put_task_struct() soon after. > >Use find_task_by_pid_ns() instead of find_pid_ns + get_pid_task and kill > >kill put_task_struct(), this allows to do get_task_struct() only once > > remove the duplicated 'kill' in the above.
Done,
> LGTM. > > Acked-by: Yonghong Song <yonghong.song@linux.dev>
Thanks, I'll send V2 with your ack included in a minute.
Oleg.
| |