Messages in this thread | | | Date | Tue, 22 Aug 2023 13:31:49 +0200 | From | Greg KH <> | Subject | Re: [PATCH AUTOSEL 6.4 18/54] thermal: core: constify params in thermal_zone_device_register |
| |
On Tue, Aug 22, 2023 at 12:43:08PM +0200, Pavel Machek wrote: > Hi! > > > [ Upstream commit 80ddce5f2dbd0e83eadc9f9d373439180d599fe5 ] > > > > Since commit 3d439b1a2ad3 ("thermal/core: Alloc-copy-free the thermal zone > > parameters structure"), thermal_zone_device_register() allocates a copy > > of the tzp argument and callers need not explicitly manage its lifetime. > > > > This means the function no longer cares about the parameter being > > mutable, so constify it. > > > > No functional change. > > Not a bugfix, should not be in stable. > > 3d439b1a2ad3 ("thermal/core: Alloc-copy-free the thermal zone > parameters structure") is not in 6.1, so this is not correct patch for > 6.1. > > Why was this selected for AUTOSEL? Can you make sure patches marked > "No functional change." are not selected in future?
No, because sometimes they are needed in later patches. And marking things const is good :)
thanks,
greg k-h
| |