Messages in this thread | | | Subject | Re: [net PATCH V3 1/3] octeontx2-pf: Fix PFC TX scheduler free | From | Paolo Abeni <> | Date | Tue, 22 Aug 2023 12:58:04 +0200 |
| |
On Tue, 2023-08-22 at 09:11 +0200, Simon Horman wrote: > On Mon, Aug 21, 2023 at 10:55:14AM +0530, Suman Ghosh wrote: > > During PFC TX schedulers free, flag TXSCHQ_FREE_ALL was being set > > which caused free up all schedulers other than the PFC schedulers. > > This patch fixes that to free only the PFC Tx schedulers. > > > > Fixes: 99c969a83d82 ("octeontx2-pf: Add egress PFC support") > > Signed-off-by: Suman Ghosh <sumang@marvell.com> > > --- > > .../ethernet/marvell/octeontx2/nic/otx2_common.c | 1 + > > .../ethernet/marvell/octeontx2/nic/otx2_dcbnl.c | 15 ++++----------- > > 2 files changed, 5 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > > index 77c8f650f7ac..289371b8ce4f 100644 > > --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_common.c > > @@ -804,6 +804,7 @@ void otx2_txschq_free_one(struct otx2_nic *pfvf, u16 lvl, u16 schq) > > > > mutex_unlock(&pfvf->mbox.lock); > > } > > +EXPORT_SYMBOL(otx2_txschq_free_one); > > Hi Suman, > > Given that the licence of both this file and otx2_dcbnl.c is GPLv2, > I wonder if EXPORT_SYMBOL_GPL would be more appropriate here.
AFAICS all the symbols exported by otx2_common use plain EXPORT_SYMBOL(). I think we can keep that for consistency in a -net patch. In the long run it would be nice to move all of them to EXPORT_SYMBOL_GPL :)
Cheers,
Paolo
| |