lkml.org 
[lkml]   [2023]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH AUTOSEL 4.14 7/9] fs/nls: make load_nls() take a const parameter
On Sun 2023-08-13 12:14:25, Sasha Levin wrote:
> From: Winston Wen <wentao@uniontech.com>
>
> [ Upstream commit c1ed39ec116272935528ca9b348b8ee79b0791da ]
>
> load_nls() take a char * parameter, use it to find nls module in list or
> construct the module name to load it.
>
> This change make load_nls() take a const parameter, so we don't need do
> some cast like this:
>
> ses->local_nls = load_nls((char *)ctx->local_nls->charset);

Nice cleanup, but should not be in stable.

Best regards,
Pavel

> Suggested-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Winston Wen <wentao@uniontech.com>
> Reviewed-by: Paulo Alcantara <pc@manguebit.com>
> Reviewed-by: Christian Brauner <brauner@kernel.org>
> Signed-off-by: Steve French <stfrench@microsoft.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
> fs/nls/nls_base.c | 4 ++--
> include/linux/nls.h | 2 +-

--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-08-22 12:47    [W:3.980 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site