Messages in this thread | | | Date | Wed, 23 Aug 2023 10:38:25 +0800 | Subject | Re: [PATCH drivers/perf: hisi: 1/2] drivers/perf: hisi: hns3: default use hardware event 0 as group leader event. | From | Jijie Shao <> |
| |
on 2023/8/21 19:58, Will Deacon wrote: > On Wed, Aug 16, 2023 at 05:46:18PM +0800, Jijie Shao wrote: >> From: Hao Chen <chenhao418@huawei.com> >> >> For hns3 pmu events, we use command as below before: >> perf stat -g -e hns3_pmu_sicl_0/config=0x00105,global=1/ >> -e hns3_pmu_sicl_0/config=0x10105,global=1/ -I 1000 >> >> We want to use -g parameter to make 0x00105 event and 0x10105 event >> share a hardware event, but for kernel 6.2, 'commit 5f8f95673f68 >> ("perf evlist: Remove group option.")' remove -g parameter. >> >> So add this patch to set default related event idx as 0 to share >> the first hardware event. > Hmm, but the change cited above is a userspace change so I don't think > we should be making driver-side changes for that. Furthermore, the commit > message there suggests that you should be using a different syntax, > introduced by 89efb029502d ("perf tools: Add support to parse event > group syntax") (which describes the grammer and has some examples too). > > Will
Thanks for your introduction, we are retesting this scenario as
89efb029502d("perf tools: Add support to parse eventgroup syntax")
Jijie Shao
| |