lkml.org 
[lkml]   [2023]   [Aug]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 02/11] mfd: mt6358: Add registers for MT6366 specific regulators
From
On 22/08/2023 10:45, Chen-Yu Tsai wrote:
> The MT6366 PMIC, compared to the MT6358, does away with the VCAM*
> regulators. Two regulators VM18 and VMDDR reuse their register space.
> There's also a VSRAM type regulator VSRAM_CORE thats' split between
> the VCAM* register space and other parts.
>
> Add register address macros for these MT6366 specific regulators.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> include/linux/mfd/mt6358/registers.h | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>

Adding few defines without any code using it barely fits one logical
change. It's just not a change, even if AMD tells you otherwise with
their autogenerated headers. I think this should be squashed with its user.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-08-22 21:38    [W:0.224 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site