Messages in this thread | | | Date | Tue, 22 Aug 2023 08:58:21 +0200 | From | Nam Cao <> | Subject | Re: [PATCH] staging: axis-fifo: fix alignment of open parenthesis |
| |
On Tue, Aug 22, 2023 at 10:04:26AM +0530, Rohit Chavan wrote: > Fixed all CHECK: Alignment should match open parenthesis > as reported by checkpatch to adhere to the Linux kernel > coding-style guidelines. > > Signed-off-by: Rohit Chavan <roheetchavan@gmail.com> > --- > drivers/staging/axis-fifo/axis-fifo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c > index 727b956aa231..d0ca82a755e4 100644 > --- a/drivers/staging/axis-fifo/axis-fifo.c > +++ b/drivers/staging/axis-fifo/axis-fifo.c > @@ -381,7 +381,7 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf, > */ > mutex_lock(&fifo->read_lock); > ret = wait_event_interruptible_timeout(fifo->read_queue, > - ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), > + ioread32(fifo->base_addr + XLLF_RDFO_OFFSET), > read_timeout);
This "read_timeout" should have the same indentation as the line above.
> > if (ret <= 0) { > @@ -522,7 +522,7 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf, > */ > mutex_lock(&fifo->write_lock); > ret = wait_event_interruptible_timeout(fifo->write_queue, > - ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) > + ioread32(fifo->base_addr + XLLF_TDFV_OFFSET) > >= words_to_write, > write_timeout);
Also here, this looks very ugly after your change :(
Best regards, Nam
| |