Messages in this thread | | | Date | Mon, 21 Aug 2023 20:21:41 +0100 | Subject | Re: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3 | From | Bryan O'Donoghue <> |
| |
On 21/08/2023 19:51, Bryan O'Donoghue wrote: > On 21/08/2023 10:53, Hans Verkuil wrote: >> + u8 dt_id = vc * 4; > > You're right. > > dt_id = vc is wrong but so is dt_id = vc * 4. > > I'll post a fix for the dt_id as a separate patch. > > --- > bod
No wait.. dt_id = vc is _fine_
I'll add a patch to document what this does since the provenance of the changes for this value are undocumented and confusing even to me, with access to the documentation for it.
--- bod
| |