lkml.org 
[lkml]   [2023]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v0 8/9] media: qcom: camss: Fix set CSI2_RX_CFG1_VC_MODE when VC is greater than 3
From
On 21/08/2023 19:51, Bryan O'Donoghue wrote:
> On 21/08/2023 10:53, Hans Verkuil wrote:
>> +        u8 dt_id = vc * 4;
>
> You're right.
>
> dt_id = vc is wrong but so is dt_id = vc * 4.
>
> I'll post a fix for the dt_id as a separate patch.
>
> ---
> bod

No wait.. dt_id = vc is _fine_

I'll add a patch to document what this does since the provenance of the
changes for this value are undocumented and confusing even to me, with
access to the documentation for it.

---
bod

\
 
 \ /
  Last update: 2023-08-21 21:25    [W:0.904 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site