lkml.org 
[lkml]   [2023]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[irqchip: irq/irqchip-next] irqchip/loongson-eiointc: Fix return value checking of eiointc_index
The following commit has been merged into the irq/irqchip-next branch of irqchip:

Commit-ID: 2e99b73afde18853754c5fae8e8d1a66fe5e3f64
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/2e99b73afde18853754c5fae8e8d1a66fe5e3f64
Author: Bibo Mao <maobibo@loongson.cn>
AuthorDate: Fri, 11 Aug 2023 17:58:04 +08:00
Committer: Marc Zyngier <maz@kernel.org>
CommitterDate: Mon, 21 Aug 2023 17:39:21 +01:00

irqchip/loongson-eiointc: Fix return value checking of eiointc_index

Return value of function eiointc_index is int, however it is converted
into uint32_t and then compared smaller than zero, this will cause logic
problem.

Fixes: dd281e1a1a93 ("irqchip: Add Loongson Extended I/O interrupt controller support")
Signed-off-by: Bibo Mao <maobibo@loongson.cn>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230811095805.2974722-2-maobibo@loongson.cn
---
drivers/irqchip/irq-loongson-eiointc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c
index 92d8aa2..1623cd7 100644
--- a/drivers/irqchip/irq-loongson-eiointc.c
+++ b/drivers/irqchip/irq-loongson-eiointc.c
@@ -144,7 +144,7 @@ static int eiointc_router_init(unsigned int cpu)
int i, bit;
uint32_t data;
uint32_t node = cpu_to_eio_node(cpu);
- uint32_t index = eiointc_index(node);
+ int index = eiointc_index(node);

if (index < 0) {
pr_err("Error: invalid nodemap!\n");
\
 
 \ /
  Last update: 2023-08-21 18:59    [W:0.456 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site