lkml.org 
[lkml]   [2023]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 5/6] of: dynamic: Move dead property list check into property add/update functions
    Hi Rob,

    Thanks for your patch!


    On Fri, Aug 18, 2023 at 10:41 PM Rob Herring <robh@kernel.org> wrote:
    > The changeset code checks for a property in the deadprops list when
    > adding/updating a property, but of_add_property() and
    > of_update_property() do not. As the users of these functions are pretty
    > simple, they have not hit this scenario or else the property lists
    > would get corrupted.
    >
    > With this there are 3 cases of removing a property from either deadprops
    > or properties lists, so add a helper to find and remove a matching
    > property.
    >
    > Signed-off-by: Rob Herring <robh@kernel.org>

    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

    Perhaps this needs a Fixes tag?

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2023-08-21 15:06    [W:4.370 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site