lkml.org 
[lkml]   [2023]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v3 2/6] of: dynamic: Refactor action prints to not use "%pOF" inside devtree_lock
    Hi Rob,

    Thanks for the update!

    On Fri, Aug 18, 2023 at 10:41 PM Rob Herring <robh@kernel.org> wrote:
    > While originally it was fine to format strings using "%pOF" while
    > holding devtree_lock, this now causes a deadlock. Lockdep reports:
    >
    > of_get_parent from of_fwnode_get_parent+0x18/0x24
    > ^^^^^^^^^^^^^
    > of_fwnode_get_parent from fwnode_count_parents+0xc/0x28
    > fwnode_count_parents from fwnode_full_name_string+0x18/0xac
    > fwnode_full_name_string from device_node_string+0x1a0/0x404
    > device_node_string from pointer+0x3c0/0x534
    > pointer from vsnprintf+0x248/0x36c
    > vsnprintf from vprintk_store+0x130/0x3b4
    >
    > Fix this by moving the printing in __of_changeset_entry_apply() outside
    > the lock. As the only difference in the the multiple prints is the

    scripts/checkpatch.pl says: WARNING: Possible repeated word: 'the'

    > action name, use the existing "action_names" to refactor the prints into
    > a single print.
    >
    > Fixes: a92eb7621b9fb2c2 ("lib/vsprintf: Make use of fwnode API to obtain node names and separators")
    > Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
    > Signed-off-by: Rob Herring <robh@kernel.org>
    > ---
    > v6 (v3 in this series):
    > - Add check on 'action' bounds. As action is only set in
    > of_changeset_action(), add the check there.
    > - Drop printing the changeset entry pointer

    Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2023-08-21 13:52    [W:4.248 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site