Messages in this thread | | | From | Marian Postevca <> | Subject | Re: [PATCH 3/4] ASoC: amd: acp: Add machine driver that enables sound for systems with a ES8336 codec | Date | Sun, 20 Aug 2023 12:32:52 +0300 |
| |
Mark Brown <broonie@kernel.org> writes:
> You'd need to pull the relevant supplies out of DAPM and handle them in > the CODEC suspend/resume callback.
Can you please suggest an approach that would be acceptable to you? In the original patch series I sent, you didn't agree to the approach to disable the jack detection in the machine driver suspend callback and re-enable it in the resume callback. You suggested to do it in the CODEC suspend/resume callbacks. As I explained previously (and Zhu Ning confirmed in his email) this wouldn't work, since as long as the jack detection is enabled, the CODEC suspend/resume callbacks do not get called. The second option (which you also do not seem to agree) is to enable idle_bias_on.
So I don't know how to continue with this and merge this new machine driver.
| |