Messages in this thread | | | Date | Sun, 20 Aug 2023 17:58:34 +0300 | Subject | Re: [PATCH blktests v2 3/3] nvme: introduce nvmet_target_{setup/cleanup} common code | From | Sagi Grimberg <> |
| |
On 8/18/23 17:15, Daniel Wagner wrote: > Almost all fabric tests have the identically code for > setting up and cleaning up the target side. Introduce > two new helpers. > > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > tests/nvme/003 | 14 +++------- > tests/nvme/004 | 21 +++------------ > tests/nvme/005 | 20 ++------------- > tests/nvme/006 | 19 ++------------ > tests/nvme/007 | 14 ++-------- > tests/nvme/008 | 21 ++------------- > tests/nvme/009 | 16 ++---------- > tests/nvme/010 | 21 ++------------- > tests/nvme/011 | 16 ++---------- > tests/nvme/012 | 21 ++------------- > tests/nvme/013 | 16 ++---------- > tests/nvme/014 | 21 ++------------- > tests/nvme/015 | 16 ++---------- > tests/nvme/018 | 16 ++---------- > tests/nvme/019 | 21 ++------------- > tests/nvme/020 | 16 ++---------- > tests/nvme/021 | 16 ++---------- > tests/nvme/022 | 16 ++---------- > tests/nvme/023 | 21 ++------------- > tests/nvme/024 | 16 ++---------- > tests/nvme/025 | 16 ++---------- > tests/nvme/026 | 16 ++---------- > tests/nvme/027 | 17 +++---------- > tests/nvme/028 | 17 +++---------- > tests/nvme/029 | 21 ++------------- > tests/nvme/040 | 19 ++------------ > tests/nvme/041 | 18 ++----------- > tests/nvme/042 | 17 ++----------- > tests/nvme/043 | 17 ++----------- > tests/nvme/044 | 19 +++----------- > tests/nvme/045 | 18 +++---------- > tests/nvme/047 | 21 ++------------- > tests/nvme/048 | 17 ++----------- > tests/nvme/rc | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++ > 34 files changed, 141 insertions(+), 519 deletions(-) > > diff --git a/tests/nvme/003 b/tests/nvme/003 > index 71b82ce758a3..eed1f549866a 100755 > --- a/tests/nvme/003 > +++ b/tests/nvme/003 > @@ -22,15 +22,8 @@ test() { > > _setup_nvmet > > - local loop_dev > - local port > > - port="$(_create_nvmet_port "${nvme_trtype}")" > - > - loop_dev="$(losetup -f)" > - > - _create_nvmet_subsystem "${def_subsysnqn}" "${loop_dev}" > - _add_nvmet_subsys_to_port "${port}" "${def_subsysnqn}" > + _nvmet_target_setup --blkdev=device
--blkdev=device by default no?
| |