lkml.org 
[lkml]   [2023]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/5] of: Refactor node and property manipulation function locking
On Tue, Aug 01, 2023 at 03:54:48PM -0600, Rob Herring wrote:
> All callers of __of_{add,remove,update}_property() and
> __of_{attach,detach}_node() wrap the call with the devtree_lock
> spinlock. Let's move the spinlock into the functions. This allows moving
> the sysfs update functions into those functions as well.

...

> +out:

out_unlock: ?

> + raw_spin_unlock_irqrestore(&devtree_lock, flags);
> + if (!rc)
> + __of_add_property_sysfs(np, prop);
> +
> + return rc;

Why not

if (rc)
return rc;

__of_add_property_sysfs(np, prop);
return 0;

?

...

> +out:
> + raw_spin_unlock_irqrestore(&devtree_lock, flags);
> + if (!rc)
> + __of_remove_property_sysfs(np, prop);
> + return rc;

As per above.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-08-02 17:24    [W:0.143 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site