Messages in this thread | | | Date | Wed, 02 Aug 2023 16:19:04 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH v8 11/19] sh: add <asm-generic/io.h> including |
| |
On Tue, Aug 1, 2023, at 21:21, John Paul Adrian Glaubitz wrote:
>> I think ideally all the I/O port stuff in arch/sh/ could just be >> removed after the conversion to asm-generic/io.h, but the >> microdev_ioport_map() function oddity gets in the way of that, >> unless someone wants to clean up that platform. As far as I >> can tell, the ethernet, display, USB and PCI devices on it already >> broke at some point (afbb9d8d5266b, 46bc85872040a), so it might >> be easier to remove it entirely. > > I don't have this particular hardware, so I cannot comment on this.
Sure, as I explained, I'm pretty sure that nobody has tried to boot this hardware in a long time, so I did not expect you to have one.
I'll try to follow up with a patch to remove the platform later on, based on the explations above.
>> Having the series go into linux-next sounds appropriate like this, >> the entire purpose of that is to find such bugs and Andrew can jus >> fold the fixup into the broken patch. >> >> Let me know if you prefer the simple version with the extra >> #defines or if we should just use the generic inb/outb implementation >> immediately and drop microdev in a separate patch. > > Please go ahead with the simple version.
Done,
Arnd
| |