Messages in this thread | | | Date | Wed, 2 Aug 2023 18:49:15 +0530 | Subject | Re: [PATCH 3/8] arm64: dts: qcom: Add PMIC pm7550ba dtsi | From | Rohit Agarwal <> |
| |
On 8/2/2023 6:44 PM, Konrad Dybcio wrote: > On 2.08.2023 15:13, Rohit Agarwal wrote: >> On 8/2/2023 6:12 PM, Konrad Dybcio wrote: >>> On 2.08.2023 11:59, Rohit Agarwal wrote: >>>> Add dtsi for PMIC pm7550ba found in Qualcomm platforms. >>>> >>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>>> --- >>> Subject: "PMIC pm7550ba" -> "pm7550ba PMIC" >>> >>> [...] >>> >>>> + >>>> + pm7550ba_eusb2_repeater: phy@fd00 { >>>> + compatible = "qcom,pm8550b-eusb2-repeater"; >>> A new compatible should be introduced, so that it goes like this: >>> >>> compatible = "qcom,pm7550ba-eusb2-repeater", "qcom,pm8550b-eusb2-repeater"; >> Just a doubt, Since the compatible can be same why we need to introduce a new compatible. >> Should every soc have a compatible string? > If it turns out that we need to add a quirk for PM7550BA 3 years down > the line, this approach lets us fix it for users that never updated > their device trees. Yes. Got it.
Thanks, Rohit > > Konrad
| |