Messages in this thread | | | Date | Wed, 2 Aug 2023 18:47:47 +0530 | Subject | Re: [PATCH 7/8] arm64: dts: qcom: sdx75: Add rpmhpd node | From | Rohit Agarwal <> |
| |
On 8/2/2023 6:18 PM, Konrad Dybcio wrote: > On 2.08.2023 11:59, Rohit Agarwal wrote: >> Add rpmhpd node and opps for this node to the SDX75 dts. >> >> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/sdx75.dtsi | 51 +++++++++++++++++++++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi >> index 5e9602cd..3a1d37a 100644 >> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi >> @@ -9,6 +9,7 @@ >> #include <dt-bindings/clock/qcom,rpmh.h> >> #include <dt-bindings/clock/qcom,sdx75-gcc.h> >> #include <dt-bindings/interrupt-controller/arm-gic.h> >> +#include <dt-bindings/power/qcom,rpmhpd.h> >> #include <dt-bindings/soc/qcom,rpmh-rsc.h> >> >> / { >> @@ -666,6 +667,56 @@ >> clock-names = "xo"; >> #clock-cells = <1>; >> }; >> + >> + rpmhpd: power-controller { >> + compatible = "qcom,sdx75-rpmhpd"; >> + #power-domain-cells = <1>; >> + operating-points-v2 = <&rpmhpd_opp_table>; >> + >> + rpmhpd_opp_table: opp-table { >> + compatible = "operating-points-v2"; >> + >> + rpmhpd_opp_ret: opp1 { > Please use opp-(value-of-opp-level) here, we've hit a few cases > where introducing levels inbetween was necessary and this would > limit the diff if that was the case again, so opp-16 etc. Will update this as well
Thanks, Rohit. > > Konrad
| |