Messages in this thread | | | Date | Wed, 2 Aug 2023 09:42:39 +0200 | From | Francesco Dolcini <> | Subject | Re: [PATCH v1 2/2] arm64: dts: ti: k3-am625-verdin: enable CAN_2 |
| |
On Tue, Aug 01, 2023 at 10:43:25PM -0500, Nishanth Menon wrote: > On 15:36-20230724, Francesco Dolcini wrote: > [...] > > > + /* Verdin CAN_2 */ > > + pinctrl_mcu_mcan0: mcu-mcan0-default-pins { > > + pinctrl-single,pins = < > > + AM62X_MCU_IOPAD(0x0038, PIN_INPUT, 0) /* (B3) MCU_MCAN0_RX */ /* SODIMM 26 */ > > + AM62X_MCU_IOPAD(0x0034, PIN_OUTPUT, 0) /* (D6) MCU_MCAN0_TX */ /* SODIMM 24 */ > > This is minor - I realize we already accepted this, but: > /* (B3) MCU_MCAN0_RX */ /* SODIMM 26 */ > Vs > /* (B3) MCU_MCAN0_RX - SODIMM 26 */ > > I wonder if you'd like the second style.
For sure I do not like to have the file with 2 different styles, and to me this is just a taste thingy that would not justify updating the whole file.
I'll keep it as it is.
Francesco
| |