lkml.org 
[lkml]   [2023]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/5] mmc: au1xmmc: force non-modular build and remove symbol_get usage
On Tue, Aug 1, 2023 at 7:36 PM Christoph Hellwig <hch@lst.de> wrote:
>
> au1xmmc is split somewhat awkwardly into the main mmc subsystem driver,
> and callbacks in platform_data that sit under arch/mips/ and are
> always built in. The latter than call mmc_detect_change through
> symbol_get. Remove the use of symbol_get by requiring the driver
> to be built in. In the future the interrupt handlers for card
> insert/eject detection should probably be moved into the main driver,
> and which point it can be built modular again.

The carddetection stuff is entirely system-specific, I don't want the driver
littered with board-custom stuff; I'm fine with it being built-in only.


> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> arch/mips/alchemy/devboards/db1000.c | 8 +-------
> arch/mips/alchemy/devboards/db1200.c | 19 ++-----------------
> arch/mips/alchemy/devboards/db1300.c | 10 +---------
> drivers/mmc/host/Kconfig | 4 ++--
> 4 files changed, 6 insertions(+), 35 deletions(-)

Ok For me. If it matters:

Acked-by: Manuel Lauss <manuel.lauss@gmail.com>

Thanks!
Manuel

\
 
 \ /
  Last update: 2023-08-02 09:16    [W:2.204 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site