lkml.org 
[lkml]   [2023]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: Re: [PATCH net] octeontx2-pf: Set maximum queue size to 16K
Date
> From: Alexander Lobakin <aleksander.lobakin@intel.com>
> Sent: Wednesday, August 2, 2023 9:42 PM
> To: Ratheesh Kannoth <rkannoth@marvell.com>
> Subject: [EXT] Re: [PATCH net] octeontx2-pf: Set maximum queue size to 16K

> +ring->rx_max_pending = 16384; /* Page pool support on RX */
>
> This is very hardcodish. Why not limit the Page Pool size when creating
> instead? It's perfectly fine to have a queue with 64k descriptors and a Page
> Pool with only ("only" :D) 16k elements.
> Page Pool size affects only the size of the embedded ptr_ring, which is used
> for indirect (locking) recycling. I would even recommend to not go past 2k for
> PP sizes, it makes no sense and only consumes memory.

These recycling will impact on performance, right ? else, why didn't page pool made this size as constant.


\
 
 \ /
  Last update: 2023-08-03 04:09    [W:0.102 / U:2.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site