Messages in this thread | | | From | Nick Desaulniers <> | Date | Wed, 2 Aug 2023 14:26:43 -0700 | Subject | Re: [PATCH] clk: ralink: mtmips: quiet unused variable warning |
| |
On Wed, Aug 2, 2023 at 2:26 AM Sergio Paracuellos <sergio.paracuellos@gmail.com> wrote: > > When CONFIG_OF is disabled then the matching table is not referenced and > the following warning appears: > > drivers/clk/ralink/clk-mtmips.c:821:34: warning: unused variable 'mtmips_of_match' [-Wunused-const-variable] > 821 | static const struct of_device_id mtmips_of_match[] = { > | ^ > > Silence it declaring 'mtmips_of_match' with '__maybe_unused'. > > Fixes: 6f3b15586eef ("clk: ralink: add clock and reset driver for MTMIPS SoCs") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202307242310.CdOnd2py-lkp@intel.com/ > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
I think this is fine; Arnd or Nathan do you have a preference? or thoughts here?
If not, thanks for the patch. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
(I have a slight preference for wrapping the use in `#ifdef CONFIG_OF` since with the approach used by this patch, if all users are removed we will never get a warning for this var. But it's a weak preference; it's more important to me that we don't have -Werror promote this warning to a build breakage)
> --- > drivers/clk/ralink/clk-mtmips.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clk/ralink/clk-mtmips.c b/drivers/clk/ralink/clk-mtmips.c > index 1e7991439527..6716394b28a3 100644 > --- a/drivers/clk/ralink/clk-mtmips.c > +++ b/drivers/clk/ralink/clk-mtmips.c > @@ -820,7 +820,7 @@ static const struct mtmips_clk_data mt76x8_clk_data = { > .num_clk_periph = ARRAY_SIZE(mt76x8_pherip_clks), > }; > > -static const struct of_device_id mtmips_of_match[] = { > +static const __maybe_unused struct of_device_id mtmips_of_match[] = { > { > .compatible = "ralink,rt2880-sysc", > .data = &rt2880_clk_data, > -- > 2.25.1 >
-- Thanks, ~Nick Desaulniers
| |