Messages in this thread | | | Date | Wed, 2 Aug 2023 08:56:47 -0700 | Subject | Re: [PATCH] scsi: ufs: qcom: Make struct ufs_qcom_bw_table static const | From | Bart Van Assche <> |
| |
On 8/1/23 21:01, Manivannan Sadhasivam wrote: > ufs_qcom_bw_table is not modified anywhere. So make it static const so that > it can be placed in read-only memory. > > Reported-by: Bart Van Assche <bvanassche@acm.org> > Closes: https://lore.kernel.org/linux-scsi/43cd0057-c6d8-bc92-08f4-d767336d2cfe@acm.org/ > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/ufs/host/ufs-qcom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c > index 75a1fd295f34..0341c025e818 100644 > --- a/drivers/ufs/host/ufs-qcom.c > +++ b/drivers/ufs/host/ufs-qcom.c > @@ -58,7 +58,7 @@ enum { > MODE_MAX, > }; > > -struct __ufs_qcom_bw_table { > +static const struct __ufs_qcom_bw_table { > u32 mem_bw; > u32 cfg_bw; > } ufs_qcom_bw_table[MODE_MAX + 1][QCOM_UFS_MAX_GEAR + 1][QCOM_UFS_MAX_LANE + 1] = {
Thanks!
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
| |