lkml.org 
[lkml]   [2023]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 3/4] clk: qcom: common: add _qcom_cc_really_probe
From


On 8/19/2023 10:54 AM, Bjorn Andersson wrote:
> On Fri, Aug 18, 2023 at 04:35:52PM +0800, Jie Luo wrote:
>> On 8/18/2023 11:14 AM, Bjorn Andersson wrote:
>>> On Tue, Aug 15, 2023 at 04:52:04PM +0800, Luo Jie wrote:
> [..]
>>>> +int qcom_cc_really_probe(struct platform_device *pdev,
>>>> + const struct qcom_cc_desc *desc, struct regmap *regmap)
>>>
>>> Why do we want to keep this wrapper around?
>>>
>> There are many existed clock controller drivers using this wrapper
>> qcom_cc_really_probe, so i still keep this wrapper.
>>
>> do we need to remove this wrapper and update the existed drivers to use
>> _qcom_cc_really_probe?
>
> Yes please. The additional API does not add value, but can be confusing,
> so let's invest the extra time in fixing up all the drivers to keep the
> interface clean.
>
> Regards,
> Bjorn

Thanks Bjorn for the suggestion, will update this patch in the next version.

\
 
 \ /
  Last update: 2023-08-19 08:24    [W:0.079 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site