Messages in this thread | | | Date | Sat, 19 Aug 2023 05:18:39 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH 2/3] hwmon: pmbus: Drop unnecessary clear fault page |
| |
On Thu, Aug 17, 2023 at 11:25:25AM +0200, Naresh Solanki wrote: > From: Patrick Rudolph <patrick.rudolph@9elements.com> > > The pmbus_check_byte_register function already calls clear > fault page, so there's no need to do it again in > pmbus_identify_common. > > TEST: Verified using an I2C bus analyser to confirm that only > one clear fault page is being send instead of two in a row. > > Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com> > Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
Applied.
Thanks, Guenter
> --- > drivers/hwmon/pmbus/pmbus_core.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c > index cbfabdd69056..1363d9f89181 100644 > --- a/drivers/hwmon/pmbus/pmbus_core.c > +++ b/drivers/hwmon/pmbus/pmbus_core.c > @@ -2541,7 +2541,6 @@ static int pmbus_identify_common(struct i2c_client *client, > } > } > > - pmbus_clear_fault_page(client, page); > return 0; > } >
| |