Messages in this thread | | | Subject | Re: [PATCH net] net: mdio: mdio-bitbang: Fix C45 read/write protocol | From | patchwork-bot+netdevbpf@kernel ... | Date | Sat, 19 Aug 2023 11:51:39 +0000 |
| |
Hello:
This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>:
On Wed, 16 Aug 2023 21:06:52 +0300 you wrote: > Based on the original code semantic in case of Clause 45 MDIO, the address > command is supposed to be followed by the command sending the MMD address, > not the CSR address. The commit 002dd3de097c ("net: mdio: mdio-bitbang: > Separate C22 and C45 transactions") has erroneously broken that. So most > likely due to an unfortunate variable name it switched the code to sending > the CSR address. In our case it caused the protocol malfunction so the > read operation always failed with the turnaround bit always been driven to > one by PHY instead of zero. Fix that by getting back the correct > behaviour: sending MMD address command right after the regular address > command. > > [...]
Here is the summary with links: - [net] net: mdio: mdio-bitbang: Fix C45 read/write protocol https://git.kernel.org/netdev/net/c/2572ce62415c
You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
| |