Messages in this thread | | | Date | Fri, 18 Aug 2023 16:13:01 -0400 | From | Paul Moore <> | Subject | Re: [PATCH] selinux: set next pointer before attaching to list |
| |
On Aug 18, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@googlemail.com> wrote: > > Set the next pointer in filename_trans_read_helper() before attaching > the new node under construction to the list, otherwise garbage would be > dereferenced on subsequent failure during cleanup in the out goto label. > > Fixes: 430059024389 ("selinux: implement new format of filename transitions") > Signed-off-by: Christian Göttsche <cgzones@googlemail.com> > --- > security/selinux/ss/policydb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks Christian, nice catch!
I'm going to merge this into selinux/stable-6.5 with a stable tag, and assuming all goes well with the automated testing I'll send this up to Linus early next week.
-- paul-moore.com
| |