lkml.org 
[lkml]   [2023]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2] serial: 8250_bcm7271: improve bcm7271 8250 port
From


On 8/18/23 3:59 AM, Andy Shevchenko wrote:
> On Thu, Aug 17, 2023 at 02:13:18PM -0700, Justin Chen wrote:
>> The 8250 BCM7271 UART is not a direct match to PORT_16550A and other
>> generic ports do not match its hardware capabilities. PORT_ALTR matches
>> the rx trigger levels, but its vendor configurations are not compatible.
>> Unfortunately this means we need to create another port to fully capture
>> the hardware capabilities of the BCM7271 UART.
>>
>> To alleviate some latency pressures, we default the rx trigger level to 8.
>
> ...
>
>> + .flags = UART_CAP_FIFO | UART_CAP_AFE
>
> Leave trailing comma
>

Acked

> ...
>
>> +/* Broadcom BCM7271 UART */
>> +#define PORT_BCM7271 76
>
> 13 is free why not using it?
>

I was looking for a number close to another Broadcom port. I was
prioritizing locality. But I have no issues with 13, I will change in v3.

Thanks,
Justin


[unhandled content-type:application/pkcs7-signature]
\
 
 \ /
  Last update: 2023-08-18 21:23    [W:1.114 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site