lkml.org 
[lkml]   [2023]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] leds: pca955x: fix -Wvoid-pointer-to-enum-cast warning
On Fri, 18 Aug 2023, Nathan Chancellor wrote:

> On Fri, Aug 18, 2023 at 05:01:54PM +0100, Lee Jones wrote:
> > On Wed, 16 Aug 2023, Justin Stitt wrote:
> >
> > > When building with clang 18 I see the following warning:
> > > | drivers/leds/leds-pca955x.c:487:15: warning: cast to smaller integer
> > > | type 'enum pca955x_type' from 'const void *' [-Wvoid-pointer-to-enum-cast]
> > > | 487 | chip_type = (enum pca955x_type)md;
> > >
> > > This is due to the fact that `md` is a void* while `enum pca995x_type` has the
> > > size of an int.
> > >
> > > Add uintptr_t cast to silence clang warning while also keeping enum cast
> > > for readability and consistency with other `chip_type` assignment just a
> > > few lines below:
> > > | chip_type = (enum pca955x_type)id->driver_data;
> > >
> > > Link: https://github.com/ClangBuiltLinux/linux/issues/1910
> > > Reported-by: Nathan Chancellor <nathan@kernel.org>
> >
> > A review from Nathan would be good here.
>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>

Thank you.

--
Lee Jones [李琼斯]

\
 
 \ /
  Last update: 2023-08-18 19:40    [W:1.436 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site