lkml.org 
[lkml]   [2023]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4 2/2] gpio: mlxbf3: Support add_pin_ranges()
Date
> > Support add_pin_ranges() so that pinctrl_gpio_request() can be called.
> > The GPIO value is not modified when the user runs the "gpioset" tool.
> > This is because when gpiochip_generic_request is invoked by the
> > gpio-mlxbf3 driver, "pin_ranges" is empty so it skips "pinctrl_gpio_request()".
> > pinctrl_gpio_request() is essential in the code flow because it
> > changes the mux value so that software has control over modifying the GPIO
> value.
> > Adding add_pin_ranges() creates a dependency on the pinctrl-mlxbf3.c driver.
> >
> > Fixes: cd33f216d24 ("gpio: mlxbf3: Add gpio driver support")
> > Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
>
> You ignored my tag, why?

Oh, you already gave me a "Reviewed-By". Sorry I missed that. And Thank you! I will send a v5 with the tag.

Thanks.
Asmaa
\
 
 \ /
  Last update: 2023-08-18 16:29    [W:0.088 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site