lkml.org 
[lkml]   [2023]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 02/13] media: qcom: camss: Start to move to module compat matched resources
From
On 17.08.2023 16:38, Bryan O'Donoghue wrote:
> There is a lot of unnecessary if/elsing in this code that arguably
> should never have made it upstream when adding a second let alone
> subsequent SoC.
>
> I'm guilty of not fixing the mess myself when adding in the sm8250.
> Before adding in any new SoCs or resources lets take the time to cleanup
> the resource passing.
>
> First step is to pass the generic struct camss_resources as a parameter
> per the compatible list.
>
> Subsequent patches will address the other somewhat dispirate strutures
> which we are also doing if/else on and assigning statically.
>
> Squashed down a commit to drop useless NULL assignment for ispif resources.
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad

\
 
 \ /
  Last update: 2023-08-18 14:23    [W:0.119 / U:1.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site