Messages in this thread | | | Date | Fri, 18 Aug 2023 15:05:32 -0700 | Subject | Re: [PATCH v5 24/24] x86/resctrl: Separate arch and fs resctrl locks | From | Fenghua Yu <> |
| |
Hi, James,
On 7/28/23 09:42, James Morse wrote: > resctrl has one mutex that is taken by the architecture specific code, > and the filesystem parts. The two interact via cpuhp, where the > architecture code updates the domain list. Filesystem handlers that > walk the domains list should not run concurrently with the cpuhp > callback modifying the list. > > Exposing a lock from the filesystem code means the interface is not > cleanly defined, and creates the possibility of cross-architecture > lock ordering headaches. The interaction only exists so that certain > filesystem paths are serialised against cpu hotplug. The cpu hotplug > code already has a mechanism to do this using cpus_read_lock(). > > MPAM's monitors have an overflow interrupt, so it needs to be possible > to walk the domains list in irq context. RCU is ideal for this, > but some paths need to be able to sleep to allocate memory. > > Because resctrl_{on,off}line_cpu() take the rdtgroup_mutex as part > of a cpuhp callback, cpus_read_lock() must always be taken first. > rdtgroup_schemata_write() already does this. > > Most of the filesystem code's domain list walkers are currently > protected by the rdtgroup_mutex taken in rdtgroup_kn_lock_live(). > The exceptions are rdt_bit_usage_show() and the mon_config helpers > which take the lock directly. > > Make the domain list protected by RCU. An architecture-specific > lock prevents concurrent writers. rdt_bit_usage_show() can > walk the domain list under rcu_read_lock(). The mon_config helpers > send multiple IPIs, take the cpus_read_lock() in these cases. > > The other filesystem list walkers need to be able to sleep. > Add cpus_read_lock() to rdtgroup_kn_lock_live() so that the > cpuhp callbacks can't be invoked when file system operations are > occurring. > > Add lockdep_assert_cpus_held() in the cases where the > rdtgroup_kn_lock_live() call isn't obvious. > > Resctrl's domain online/offline calls now need to take the > rdtgroup_mutex themselves. > > Tested-by: Shaopeng Tan <tan.shaopeng@fujitsu.com> > Signed-off-by: James Morse <james.morse@arm.com> > --- > Changes since v2: > * Reworded a comment, > * Added a lockdep assertion > * Moved clear_closid_rmid() outside the locked region of cpu > online/offline > > Changes since v3: > * Added a header include > --- > arch/x86/kernel/cpu/resctrl/core.c | 38 +++++++++----- > arch/x86/kernel/cpu/resctrl/ctrlmondata.c | 16 ++++-- > arch/x86/kernel/cpu/resctrl/monitor.c | 4 ++ > arch/x86/kernel/cpu/resctrl/pseudo_lock.c | 3 ++ > arch/x86/kernel/cpu/resctrl/rdtgroup.c | 64 ++++++++++++++++++++--- > include/linux/resctrl.h | 2 +- > 6 files changed, 101 insertions(+), 26 deletions(-) > > diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c > index edc0dd123317..f106c68a9be8 100644 > --- a/arch/x86/kernel/cpu/resctrl/core.c > +++ b/arch/x86/kernel/cpu/resctrl/core.c > @@ -25,8 +25,15 @@ > #include <asm/resctrl.h> > #include "internal.h" > > -/* Mutex to protect rdtgroup access. */ > -DEFINE_MUTEX(rdtgroup_mutex); > +/* > + * rdt_domain structures are kfree()d when their last CPU goes offline, > + * and allocated when the first CPU in a new domain comes online. > + * The rdt_resource's domain list is updated when this happens. Readers of > + * the domain list must either take cpus_read_lock(), or rely on an RCU > + * read-side critical section, to avoid observing concurrent modification. > + * All writers take this mutex: > + */ > +static DEFINE_MUTEX(domain_list_lock); > > /* > * The cached resctrl_pqr_state is strictly per CPU and can never be > @@ -508,6 +515,8 @@ static void domain_add_cpu(int cpu, struct rdt_resource *r) > struct rdt_domain *d; > int err; > > + lockdep_assert_held(&domain_list_lock); > + > d = rdt_find_domain(r, id, &add_pos); > if (IS_ERR(d)) { > pr_warn("Couldn't find cache id for CPU %d\n", cpu); > @@ -541,11 +550,12 @@ static void domain_add_cpu(int cpu, struct rdt_resource *r) > return; > } > > - list_add_tail(&d->list, add_pos); > + list_add_tail_rcu(&d->list, add_pos); > > err = resctrl_online_domain(r, d); > if (err) { > - list_del(&d->list); > + list_del_rcu(&d->list); > + synchronize_rcu(); > domain_free(hw_dom); > } > } > @@ -556,6 +566,8 @@ static void domain_remove_cpu(int cpu, struct rdt_resource *r) > struct rdt_hw_domain *hw_dom; > struct rdt_domain *d; > > + lockdep_assert_held(&domain_list_lock); > + > d = rdt_find_domain(r, id, NULL); > if (IS_ERR_OR_NULL(d)) { > pr_warn("Couldn't find cache id for CPU %d\n", cpu); > @@ -566,7 +578,8 @@ static void domain_remove_cpu(int cpu, struct rdt_resource *r) > cpumask_clear_cpu(cpu, &d->cpu_mask); > if (cpumask_empty(&d->cpu_mask)) { > resctrl_offline_domain(r, d); > - list_del(&d->list); > + list_del_rcu(&d->list); > + synchronize_rcu(); > > /* > * rdt_domain "d" is going to be freed below, so clear > @@ -594,30 +607,29 @@ static void clear_closid_rmid(int cpu) > static int resctrl_arch_online_cpu(unsigned int cpu) > { > struct rdt_resource *r; > - int ret; > > - mutex_lock(&rdtgroup_mutex); > + mutex_lock(&domain_list_lock); > for_each_capable_rdt_resource(r) > domain_add_cpu(cpu, r); > + mutex_unlock(&domain_list_lock); > + > clear_closid_rmid(cpu); > > - ret = resctrl_online_cpu(cpu); > - mutex_unlock(&rdtgroup_mutex); > - > - return ret; > + return resctrl_online_cpu(cpu); > } > > static int resctrl_arch_offline_cpu(unsigned int cpu) > { > struct rdt_resource *r; > > - mutex_lock(&rdtgroup_mutex); > resctrl_offline_cpu(cpu); > > + mutex_lock(&domain_list_lock); > for_each_capable_rdt_resource(r) > domain_remove_cpu(cpu, r); > + mutex_unlock(&domain_list_lock); > + > clear_closid_rmid(cpu); > - mutex_unlock(&rdtgroup_mutex); > > return 0; > } > diff --git a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c > index 55bad57a7bd5..b4f611359d1e 100644 > --- a/arch/x86/kernel/cpu/resctrl/ctrlmondata.c > +++ b/arch/x86/kernel/cpu/resctrl/ctrlmondata.c > @@ -209,6 +209,9 @@ static int parse_line(char *line, struct resctrl_schema *s, > struct rdt_domain *d; > unsigned long dom_id; > > + /* Walking r->domains, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held(); > + > if (rdtgrp->mode == RDT_MODE_PSEUDO_LOCKSETUP && > (r->rid == RDT_RESOURCE_MBA || r->rid == RDT_RESOURCE_SMBA)) { > rdt_last_cmd_puts("Cannot pseudo-lock MBA resource\n"); > @@ -313,6 +316,9 @@ int resctrl_arch_update_domains(struct rdt_resource *r, u32 closid) > struct rdt_domain *d; > u32 idx; > > + /* Walking r->domains, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held();
When rdtgroup_schemata_write() calls resctrl_arch_update_domains(), I don't see cpus lock is held. Is it held in the path?
> + > if (!zalloc_cpumask_var(&cpu_mask, GFP_KERNEL)) > return -ENOMEM; > > @@ -378,11 +384,9 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of, > return -EINVAL; > buf[nbytes - 1] = '\0'; > > - cpus_read_lock(); > rdtgrp = rdtgroup_kn_lock_live(of->kn); > if (!rdtgrp) { > rdtgroup_kn_unlock(of->kn); > - cpus_read_unlock(); > return -ENOENT; > } > rdt_last_cmd_clear(); > @@ -444,7 +448,6 @@ ssize_t rdtgroup_schemata_write(struct kernfs_open_file *of, > out: > rdt_staged_configs_clear(); > rdtgroup_kn_unlock(of->kn); > - cpus_read_unlock(); > return ret ?: nbytes; > } > > @@ -464,6 +467,9 @@ static void show_doms(struct seq_file *s, struct resctrl_schema *schema, int clo > bool sep = false; > u32 ctrl_val; > > + /* Walking r->domains, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held(); > + > seq_printf(s, "%*s:", max_name_width, schema->name); > list_for_each_entry(dom, &r->domains, list) { > if (sep) > @@ -534,8 +540,8 @@ void mon_event_read(struct rmid_read *rr, struct rdt_resource *r, > { > int cpu; > > - /* When picking a CPU from cpu_mask, ensure it can't race with cpuhp */ > - lockdep_assert_held(&rdtgroup_mutex); > + /* When picking a cpu from cpu_mask, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held(); > > /* > * Setup the parameters to pass to mon_event_count() to read the data. > diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c b/arch/x86/kernel/cpu/resctrl/monitor.c > index 471cdc4e4eae..11b5da93044d 100644 > --- a/arch/x86/kernel/cpu/resctrl/monitor.c > +++ b/arch/x86/kernel/cpu/resctrl/monitor.c > @@ -15,6 +15,7 @@ > * Software Developer Manual June 2016, volume 3, section 17.17. > */ > > +#include <linux/cpu.h> > #include <linux/module.h> > #include <linux/percpu.h> > #include <linux/sizes.h> > @@ -484,6 +485,9 @@ static void add_rmid_to_limbo(struct rmid_entry *entry) > > lockdep_assert_held(&rdtgroup_mutex); > > + /* Walking r->domains, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held(); > + > idx = resctrl_arch_rmid_idx_encode(entry->closid, entry->rmid); > > entry->busy = 0; > diff --git a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c > index 460421051abf..fc3ed917d173 100644 > --- a/arch/x86/kernel/cpu/resctrl/pseudo_lock.c > +++ b/arch/x86/kernel/cpu/resctrl/pseudo_lock.c > @@ -830,6 +830,9 @@ bool rdtgroup_pseudo_locked_in_hierarchy(struct rdt_domain *d) > struct rdt_domain *d_i; > bool ret = false; > > + /* Walking r->domains, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held(); > + > if (!zalloc_cpumask_var(&cpu_with_psl, GFP_KERNEL)) > return true; > > diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c > index a256a96df487..47dcf2cb76ca 100644 > --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c > +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c > @@ -35,6 +35,10 @@ > DEFINE_STATIC_KEY_FALSE(rdt_enable_key); > DEFINE_STATIC_KEY_FALSE(rdt_mon_enable_key); > DEFINE_STATIC_KEY_FALSE(rdt_alloc_enable_key); > + > +/* Mutex to protect rdtgroup access. */ > +DEFINE_MUTEX(rdtgroup_mutex); > + > static struct kernfs_root *rdt_root; > struct rdtgroup rdtgroup_default; > LIST_HEAD(rdt_all_groups); > @@ -954,7 +958,8 @@ static int rdt_bit_usage_show(struct kernfs_open_file *of, > > mutex_lock(&rdtgroup_mutex); > hw_shareable = r->cache.shareable_bits; > - list_for_each_entry(dom, &r->domains, list) { > + rcu_read_lock(); > + list_for_each_entry_rcu(dom, &r->domains, list) { > if (sep) > seq_putc(seq, ';'); > sw_shareable = 0; > @@ -1010,8 +1015,10 @@ static int rdt_bit_usage_show(struct kernfs_open_file *of, > } > sep = true; > } > + rcu_read_unlock(); > seq_putc(seq, '\n'); > mutex_unlock(&rdtgroup_mutex); > + > return 0; > } > > @@ -1254,6 +1261,9 @@ static bool rdtgroup_mode_test_exclusive(struct rdtgroup *rdtgrp) > struct rdt_domain *d; > u32 ctrl; > > + /* Walking r->domains, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held(); > + > list_for_each_entry(s, &resctrl_schema_all, list) { > r = s->res; > if (r->rid == RDT_RESOURCE_MBA || r->rid == RDT_RESOURCE_SMBA) > @@ -1520,6 +1530,7 @@ static int mbm_config_show(struct seq_file *s, struct rdt_resource *r, u32 evtid > struct rdt_domain *dom; > bool sep = false; > > + cpus_read_lock(); > mutex_lock(&rdtgroup_mutex); > > list_for_each_entry(dom, &r->domains, list) { > @@ -1536,6 +1547,7 @@ static int mbm_config_show(struct seq_file *s, struct rdt_resource *r, u32 evtid > seq_puts(s, "\n"); > > mutex_unlock(&rdtgroup_mutex); > + cpus_read_unlock(); > > return 0; > } > @@ -1627,6 +1639,9 @@ static int mon_config_write(struct rdt_resource *r, char *tok, u32 evtid) > struct rdt_domain *d; > int ret = 0; > > + /* Walking r->domains, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held(); > + > next: > if (!tok || tok[0] == '\0') > return 0; > @@ -1668,6 +1683,7 @@ static ssize_t mbm_total_bytes_config_write(struct kernfs_open_file *of, > if (nbytes == 0 || buf[nbytes - 1] != '\n') > return -EINVAL; > > + cpus_read_lock(); > mutex_lock(&rdtgroup_mutex); > > rdt_last_cmd_clear(); > @@ -1677,6 +1693,7 @@ static ssize_t mbm_total_bytes_config_write(struct kernfs_open_file *of, > ret = mon_config_write(r, buf, QOS_L3_MBM_TOTAL_EVENT_ID); > > mutex_unlock(&rdtgroup_mutex); > + cpus_read_unlock(); > > return ret ?: nbytes; > } > @@ -1692,6 +1709,7 @@ static ssize_t mbm_local_bytes_config_write(struct kernfs_open_file *of, > if (nbytes == 0 || buf[nbytes - 1] != '\n') > return -EINVAL; > > + cpus_read_lock(); > mutex_lock(&rdtgroup_mutex); > > rdt_last_cmd_clear(); > @@ -1701,6 +1719,7 @@ static ssize_t mbm_local_bytes_config_write(struct kernfs_open_file *of, > ret = mon_config_write(r, buf, QOS_L3_MBM_LOCAL_EVENT_ID); > > mutex_unlock(&rdtgroup_mutex); > + cpus_read_unlock(); > > return ret ?: nbytes; > } > @@ -2153,6 +2172,9 @@ static int set_cache_qos_cfg(int level, bool enable) > struct rdt_domain *d; > int cpu; > > + /* Walking r->domains, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held(); > + > if (level == RDT_RESOURCE_L3) > update = l3_qos_cfg_update; > else if (level == RDT_RESOURCE_L2) > @@ -2360,6 +2382,7 @@ struct rdtgroup *rdtgroup_kn_lock_live(struct kernfs_node *kn) > > rdtgroup_kn_get(rdtgrp, kn); > > + cpus_read_lock(); > mutex_lock(&rdtgroup_mutex); > > /* Was this group deleted while we waited? */ > @@ -2377,6 +2400,8 @@ void rdtgroup_kn_unlock(struct kernfs_node *kn) > return; > > mutex_unlock(&rdtgroup_mutex); > + cpus_read_unlock(); > + > rdtgroup_kn_put(rdtgrp, kn); > } > > @@ -2664,6 +2689,9 @@ static int reset_all_ctrls(struct rdt_resource *r) > struct rdt_domain *d; > int i; > > + /* Walking r->domains, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held(); > + > if (!zalloc_cpumask_var(&cpu_mask, GFP_KERNEL)) > return -ENOMEM; > > @@ -2948,6 +2976,9 @@ static int mkdir_mondata_subdir_alldom(struct kernfs_node *parent_kn, > struct rdt_domain *dom; > int ret; > > + /* Walking r->domains, ensure it can't race with cpuhp */ > + lockdep_assert_cpus_held(); > + > list_for_each_entry(dom, &r->domains, list) { > ret = mkdir_mondata_subdir(parent_kn, dom, r, prgrp); > if (ret) > @@ -3766,7 +3797,8 @@ static void domain_destroy_mon_state(struct rdt_domain *d) > kfree(d->mbm_local); > } > > -void resctrl_offline_domain(struct rdt_resource *r, struct rdt_domain *d) > +static void _resctrl_offline_domain(struct rdt_resource *r, > + struct rdt_domain *d) > { > lockdep_assert_held(&rdtgroup_mutex); > > @@ -3801,6 +3833,13 @@ void resctrl_offline_domain(struct rdt_resource *r, struct rdt_domain *d) > domain_destroy_mon_state(d); > } > > +void resctrl_offline_domain(struct rdt_resource *r, struct rdt_domain *d) > +{ > + mutex_lock(&rdtgroup_mutex); > + _resctrl_offline_domain(r, d); > + mutex_unlock(&rdtgroup_mutex); > +} > + > static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d) > { > u32 idx_limit = resctrl_arch_system_num_rmid_idx(); > @@ -3832,7 +3871,7 @@ static int domain_setup_mon_state(struct rdt_resource *r, struct rdt_domain *d) > return 0; > } > > -int resctrl_online_domain(struct rdt_resource *r, struct rdt_domain *d) > +static int _resctrl_online_domain(struct rdt_resource *r, struct rdt_domain *d) > { > int err; > > @@ -3870,12 +3909,23 @@ int resctrl_online_domain(struct rdt_resource *r, struct rdt_domain *d) > return 0; > } > > +int resctrl_online_domain(struct rdt_resource *r, struct rdt_domain *d) > +{ > + int err; > + > + mutex_lock(&rdtgroup_mutex); > + err = _resctrl_online_domain(r, d); > + mutex_unlock(&rdtgroup_mutex); > + > + return err; > +} > + > int resctrl_online_cpu(unsigned int cpu) > { > - lockdep_assert_held(&rdtgroup_mutex); > - > + mutex_lock(&rdtgroup_mutex); > /* The CPU is set in default rdtgroup after online. */ > cpumask_set_cpu(cpu, &rdtgroup_default.cpu_mask); > + mutex_unlock(&rdtgroup_mutex); > > return 0; > } > @@ -3896,8 +3946,7 @@ void resctrl_offline_cpu(unsigned int cpu) > struct rdtgroup *rdtgrp; > struct rdt_resource *l3 = &rdt_resources_all[RDT_RESOURCE_L3].r_resctrl; > > - lockdep_assert_held(&rdtgroup_mutex); > - > + mutex_lock(&rdtgroup_mutex); > list_for_each_entry(rdtgrp, &rdt_all_groups, rdtgroup_list) { > if (cpumask_test_and_clear_cpu(cpu, &rdtgrp->cpu_mask)) { > clear_childcpus(rdtgrp, cpu); > @@ -3917,6 +3966,7 @@ void resctrl_offline_cpu(unsigned int cpu) > cqm_setup_limbo_handler(d, 0, cpu); > } > } > + mutex_unlock(&rdtgroup_mutex); > } > > /* > diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h > index f3ef3ceb9c5e..2bbdd3d591ea 100644 > --- a/include/linux/resctrl.h > +++ b/include/linux/resctrl.h > @@ -159,7 +159,7 @@ struct resctrl_schema; > * @cache_level: Which cache level defines scope of this resource > * @cache: Cache allocation related data > * @membw: If the component has bandwidth controls, their properties. > - * @domains: All domains for this resource > + * @domains: RCU list of all domains for this resource > * @name: Name to use in "schemata" file. > * @data_width: Character width of data when displaying > * @default_ctrl: Specifies default cache cbm or memory B/W percent.
Thanks.
-Fenghua
| |