Messages in this thread | | | Date | Thu, 17 Aug 2023 11:28:08 -0600 | From | Keith Busch <> | Subject | Re: Possible nvme regression in 6.4.11 |
| |
On Thu, Aug 17, 2023 at 05:16:01AM -0400, Genes Lists wrote: > On 8/16/23 21:30, Genes Lists wrote: > > On 8/16/23 17:04, Keith Busch wrote: > > ... > > > It sounds like you can recreate this. Since .10 worked and .11 doesn't, > > > could you bisect the git commits? It looks like it will take 7 steps > > > between those two versions. > > > > > > I don't think there are any nvme specific patches that could contribute > > > to what you're seeing, it's more likely some lower level platform patch > > > if a kernel change really did cause the regression. None of the recent > > > commits really stood out to me, so bisect is what I'd recommend. > > > > Thank you > > > > Bisect done - This is result:
Sounds like the driver's ASPM suspicion was justified, however the recommended work-around doesn't appear to apply to this hardware. Thanks for running the bisect!
> > ---------------------------------------------------------------- > > 69304c8d285b77c9a56d68f5ddb2558f27abf406 is the first bad commit > > commit 69304c8d285b77c9a56d68f5ddb2558f27abf406 > > Author: Ricky WU <ricky_wu@realtek.com> > > Date: Tue Jul 25 09:10:54 2023 +0000 > > > > misc: rtsx: judge ASPM Mode to set PETXCFG Reg > > > > commit 101bd907b4244a726980ee67f95ed9cafab6ff7a upstream. > > > > ASPM Mode is ASPM_MODE_CFG need to judge the value of clkreq_0 > > to set HIGH or LOW, if the ASPM Mode is ASPM_MODE_REG > > always set to HIGH during the initialization. > > > > Cc: stable@vger.kernel.org > > Signed-off-by: Ricky Wu <ricky_wu@realtek.com> > > Link: > > https://lore.kernel.org/r/52906c6836374c8cb068225954c5543a@realtek.com > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > drivers/misc/cardreader/rts5227.c | 2 +- > > drivers/misc/cardreader/rts5228.c | 18 ------------------ > > drivers/misc/cardreader/rts5249.c | 3 +-- > > drivers/misc/cardreader/rts5260.c | 18 ------------------ > > drivers/misc/cardreader/rts5261.c | 18 ------------------ > > drivers/misc/cardreader/rtsx_pcr.c | 5 ++++- > > 6 files changed, 6 insertions(+), 58 deletions(-) > > > > ------------------------------------------------------ > > > > And the machine does have this hardware: > > > > 03:00.0 Unassigned class [ff00]: Realtek Semiconductor Co., Ltd. RTS525A > > PCI Express Card Reader (rev 01) > > Subsystem: Dell RTS525A PCI Express Card Reader > > Physical Slot: 1 > > Flags: bus master, fast devsel, latency 0, IRQ 141 > > Memory at ed100000 (32-bit, non-prefetchable) [size=4K] > > Capabilities: [80] Power Management version 3 > > Capabilities: [90] MSI: Enable+ Count=1/1 Maskable- 64bit+ > > Capabilities: [b0] Express Endpoint, MSI 00 > > Kernel driver in use: rtsx_pci > > Kernel modules: rtsx_pci
| |