lkml.org 
[lkml]   [2023]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] can: netlink: support setting hardware filters
On Thu, 17 Aug 2023 12:10:13 +0200 Martin Hundebøll wrote:
> + int len = nla_len(data[IFLA_CAN_HW_FILTER]);
> + int num_filter = len / sizeof(struct can_filter);
> + struct can_filter *filter = nla_data(data[IFLA_CAN_HW_FILTER]);

This will prevent you from ever extending struct can_filter in
a backward-compatible fashion, right? I obviously know very little
about CAN but are you confident a more bespoke API to manipulate
filters individually and allow extensibility is not warranted?

\
 
 \ /
  Last update: 2023-08-17 18:47    [W:0.057 / U:0.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site