Messages in this thread | | | Date | Thu, 17 Aug 2023 18:47:18 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 1/8] bitmap: align __reg_op() wrappers with modern coding style |
| |
On Thu, Aug 17, 2023 at 07:22:25AM -0700, Yury Norov wrote: > On Thu, Aug 17, 2023 at 12:39:49PM +0300, Andy Shevchenko wrote: > > On Tue, Aug 15, 2023 at 04:36:21PM -0700, Yury Norov wrote: > > > Fix comments so that scripts/kernel-doc doesn't warn, and fix for-loop > > > style in bitmap_find_free_region(). > > > > Suggested-by? > > Can you send a full tag?
I thought it's easy to get... Nevertheless it's here.
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Btw, there are things needs to be fixed/improved as well: 1) bitmap_pos_to_ord(): reference to @nbits instead of @bits; 2) bitmap_parse(): wrong/confusing reference to a list, while should be better example for under 32-bit input and over it with spaces and/or commas; 3) style of the descriptions of the parameters: * @param : vs. * @param: /// preferable 4) bitmap_cut(): make nbits a reference as @nbits in some cases; 5) empty line after the function summary (should be dropped), e.g. in bitmap_parse_user(); 6) true and false can be referred )in bitmap_print_to_buf(), for example) as constants %true. %false (up to you).
Maybe something else... That said, the documentation should be revisited carefully.
-- With Best Regards, Andy Shevchenko
| |