lkml.org 
[lkml]   [2023]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 03/13] ext4: correct return value of ext4_convert_meta_bg
On Thu, Aug 17, 2023 at 10:48:51AM +0800, Kemeng Shi wrote:
>
> > errout:
> > ret = ext4_journal_stop(handle);
> > if (!err)
> > ret = err;
> > return ret;
> >
> I think you mean:
> errout:
> ret = ext4_journal_stop(handle);
> if (*err*)
> ret = err;
> return ret;
> And I will fix in this way if I don't get wrong.

Yes, that's what I meant. Another way of putting it might be:

ret = ext4_journal_stop(handle);
return (err ? err : ret);

- Ted

\
 
 \ /
  Last update: 2023-08-17 16:00    [W:0.084 / U:0.432 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site