Messages in this thread | | | Date | Thu, 17 Aug 2023 08:52:11 +0200 | From | Sebastian Andrzej Siewior <> | Subject | Re: [PATCH RESEND] scsi: fcoe: Fix potential deadlock on &fip->ctlr_lock |
| |
On 2023-08-16 15:55:24 [+0000], Chengfeng Ye wrote: > These flaws were found by an experimental static analysis tool I am > developing for irq-related deadlock.
So you did not use lockdep or is the code path so unlikely that nobody stumbled upon it before?
> The patch fix the potential deadlocks by spin_lock_irqsave() to > disable hard irq.
Shouldn't this have
Fixes: 794d98e77f590 ("[SCSI] libfcoe: retry rejected FLOGI to another FCF if possible")
?
> Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Sebastian
| |