Messages in this thread | | | Date | Thu, 17 Aug 2023 15:48:07 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v6 3/6] iio: adc: mcp3911: simplify usage of spi->dev |
| |
On Thu, Aug 17, 2023 at 02:05:15PM +0200, Marcus Folkesson wrote: > Replace the usage of `adc->spi->dev` with `dev` to make the code prettier.
...
> @@ -277,9 +278,7 @@ static int mcp3911_calc_scale_table(struct mcp3911 *adc)
> ret = regulator_get_voltage(adc->vref); > if (ret < 0) { > - dev_err(&adc->spi->dev, > - "failed to get vref voltage: %d\n", > - ret); > + dev_err(dev, "failed to get vref voltage: %d\n", ret);
So, this can be part of the previous patch as this function is the part of the ->probe() stage.
> return ret; > }
...
> @@ -396,12 +395,10 @@ static int mcp3911_config(struct mcp3911 *adc) > if (ret) > device_property_read_u32(dev, "device-addr", &adc->dev_addr); > if (adc->dev_addr > 3) { > - dev_err(&adc->spi->dev, > - "invalid device address (%i). Must be in range 0-3.\n", > - adc->dev_addr); > + dev_err(dev, "invalid device address (%i). Must be in range 0-3.\n", adc->dev_addr); > return -EINVAL;
Ditto.
> }
...
> + adc->trig = devm_iio_trigger_alloc(dev, "%s-dev%d", > + indio_dev->name, > + iio_device_id(indio_dev));
Seem you already switched to longer lines, hence this can be compressed to two lines.
> if (!adc->trig) > return -ENOMEM;
...
> + ret = devm_request_irq(dev, spi->irq, > + &iio_trigger_generic_data_rdy_poll,
In the similar way as above.
> + IRQF_NO_AUTOEN | IRQF_ONESHOT, > + indio_dev->name, adc->trig); > if (ret) > return ret;
-- With Best Regards, Andy Shevchenko
| |