Messages in this thread | | | Date | Thu, 17 Aug 2023 14:43:25 +0200 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH] powerpc/8xx: Remove init_internal_rtc() to fix no previous prototype error |
| |
On Thu, Aug 17, 2023, at 14:26, Christophe Leroy wrote: > A W=1 build of mpc885_ads_defconfig throws the following error: > > CC arch/powerpc/platforms/8xx/m8xx_setup.o > arch/powerpc/platforms/8xx/m8xx_setup.c:41:1: error: no previous > prototype for 'init_internal_rtc' [-Werror=missing-prototypes] > 41 | init_internal_rtc(void) > | ^~~~~~~~~~~~~~~~~ > > init_internal_rtc() was introduced by commit df34403dcaac ("[POWERPC] > 8xx: Add mpc885ads support and common mpc8xx files") as a weak > function but has never been defined and/or used outside m8xx_setup.c > > As it is called only once there, just fold it into its caller and > remove it. > > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> > Cc: Arnd Bergmann <arnd@arndb.de> > ---
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
| |