lkml.org 
[lkml]   [2023]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] cpufreq: cppc: Set fie_disabled to FIE_DISABLED if fails to create kworker_fie
On 17-08-23, 18:44, Liao, Chang wrote:
> Hi Viresh,
>
> 在 2023/8/17 16:56, Viresh Kumar 写道:
> > On 17-08-23, 07:47, Liao Chang wrote:
> >> The function cppc_freq_invariance_init() may failed to create
> >> kworker_fie, make it more robust by setting fie_disabled to FIE_DISBALED
> >> to prevent an invalid pointer dereference in kthread_destroy_worker(),
> >> which called from cppc_freq_invariance_exit().
> >
> > Btw, this version information present below should be added ... (see later)
> >
> >> v3:
> >> Simplify cleanup code when invariance initialization fails.
> >>
> >> v2:
> >> Set fie_disabled to FIE_DISABLED when invariance initialization fails.
> >>
> >> Link: https://lore.kernel.org/all/20230816034630.a4hvsj373q6aslk3@vireshk-i7/
> >>
> >> Signed-off-by: Liao Chang <liaochang1@huawei.com>
> >> ---
> >
> > ... here after the "---" line, this way this not-so-useful information will not
> > be committed while applying the patch.
>
> Got it, I will move the "v2:... v3:..." lines below the "---" line in next patch.

I have already applied the fixed version now, don't resend it :)

--
viresh

\
 
 \ /
  Last update: 2023-08-17 12:50    [W:0.038 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site