lkml.org 
[lkml]   [2023]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] cpufreq: Prefer to print cpuid in MIN/MAX QoS register error message
On 15-08-23, 09:40, Liao Chang wrote:
> When a cpufreq_policy is allocated, the cpus, related_cpus and real_cpus
> of policy are still unset. Therefore, it is preferable to print the
> passed 'cpu' parameter instead of a empty 'cpus' cpumask in error
> message when registering MIN/MAX QoS notifier fails.
>
> Signed-off-by: Liao Chang <liaochang1@huawei.com>
> ---
> drivers/cpufreq/cpufreq.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 50bbc969ffe5..a757f90aa9d6 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1234,16 +1234,16 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu)
> ret = freq_qos_add_notifier(&policy->constraints, FREQ_QOS_MIN,
> &policy->nb_min);
> if (ret) {
> - dev_err(dev, "Failed to register MIN QoS notifier: %d (%*pbl)\n",
> - ret, cpumask_pr_args(policy->cpus));
> + dev_err(dev, "Failed to register MIN QoS notifier: %d (CPU%u)\n",
> + ret, cpu);
> goto err_kobj_remove;
> }
>
> ret = freq_qos_add_notifier(&policy->constraints, FREQ_QOS_MAX,
> &policy->nb_max);
> if (ret) {
> - dev_err(dev, "Failed to register MAX QoS notifier: %d (%*pbl)\n",
> - ret, cpumask_pr_args(policy->cpus));
> + dev_err(dev, "Failed to register MAX QoS notifier: %d (CPU%u)\n",
> + ret, cpu);
> goto err_min_qos_notifier;
> }

Applied both the patches. Thanks.

--
viresh

\
 
 \ /
  Last update: 2023-08-17 10:45    [W:0.039 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site