lkml.org 
[lkml]   [2023]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tracefs: avoid setting i_mode to a temp value
From
Date


> On Aug 17, 2023, at 8:00 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Thu, 17 Aug 2023 19:47:34 -0400
> Sishuai Gong <sishuai.system@gmail.com> wrote:
>
>>> Can you produce this race?
>> This data race was detected when I was testing the kernel (e.g., fuzzing)
>> but I did not make the attempt to reproduce it.
>
> Now, I'm curious to what exactly is this fixing? The intermediate value is
> the S_IALLUGO bits cleared. Doesn't that mean that nothing has permission?
>
> It's not a big deal if that's the case, as it just means things are locked
> down a bit more than normal.
You are right. Even if the intermediate value is read, it is unlikely to cause anything
serious. The reader I observed is acl_permission_check(), which will not be affected
by the race.

>
> My question is, do we really care, and why should we?
This shouldn’t be a serious problem. Maybe we could consider this patch as an
annotation to the race.

>
> -- Steve
>

\
 
 \ /
  Last update: 2023-08-18 02:08    [W:0.036 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site