Messages in this thread | | | Date | Thu, 17 Aug 2023 16:45:40 -0700 | From | Kees Cook <> | Subject | Re: [PATCH] Compiler Attributes: counted_by: Adjust name and identifier expansion |
| |
On Fri, Aug 18, 2023 at 12:06:15AM +0200, Miguel Ojeda wrote: > On Thu, Aug 17, 2023 at 10:06 PM Kees Cook <keescook@chromium.org> wrote: > > > > GCC and Clang's current RFCs name this attribute "counted_by", and have > > moved away from using a string for the member name. Update the kernel's > > macros to match. Additionally provide a UAPI no-op macro for UAPI structs > > that will gain annotations. > > > > Cc: Miguel Ojeda <ojeda@kernel.org> > > Cc: Nick Desaulniers <ndesaulniers@google.com> > > Fixes: dd06e72e68bc ("Compiler Attributes: Add __counted_by macro") > > Signed-off-by: Kees Cook <keescook@chromium.org> > > Looks good to me, thanks. Perhaps we should split the UAPI bit into a > second patch.
I'd like to keep the UAPI part -- that was an oversight when I first added it.
> I can take it into my tree; otherwise if you need this elsewhere: > > Acked-by: Miguel Ojeda <ojeda@kernel.org>
Thanks! It'd be slightly easier for me if it was is my tree, so I'll grab your Ack. :) Let me know if you'd prefer it otherwise.
-Kees
-- Kees Cook
| |