Messages in this thread | | | Date | Thu, 17 Aug 2023 15:31:43 -0700 | From | Alexei Starovoitov <> | Subject | Re: [RFC PATCH bpf-next 1/2] bpf, x64: Fix tailcall infinite loop bug |
| |
On Mon, Aug 14, 2023 at 09:41:46PM +0800, Leon Hwang wrote: > @@ -1147,6 +1152,7 @@ struct bpf_attach_target_info { > struct module *tgt_mod; > const char *tgt_name; > const struct btf_type *tgt_type; > + bool tail_call_ctx;
Instead of extra flag here can you check tgt_prog->aux->tail_call_reachable in check_attach_btf_id() and set tr->flags there? Other than this the fix makes sense. Please trim your cc list when you respin. Just maintainers, Maciej (author of fixes tag) and bpf@vger is enough.
| |